Skip to content

Conversation

@nugaon
Copy link
Member

@nugaon nugaon commented Sep 11, 2025

Fixes #4450 #4822

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@nugaon nugaon marked this pull request as ready for review September 11, 2025 19:35
@gacevicljubisa
Copy link
Member

gacevicljubisa commented Sep 16, 2025

I have approved. The only comment that I have is that the mapStructure method should focus purely on data transformation (mapping input to struct) and return errors, while HTTP response handling should be completely separate. But this was already there before this PR.

There is no need for this status to be checked for each endpoint where we are calling the mapStructure. In future this can grow and lead to unexpected responses and it definitely complicates the logic of the mapStructure.

@nugaon
Copy link
Member Author

nugaon commented Sep 22, 2025

from the practical perspective, I somewhat agree with the response handling as it is now because otherwise the error responses should be handled the same way on each endpoint which is redundant. Nevertheless, you are also right about these specific errors are not necessary to be checked in every case. From my side, I would go with this as it is a fix PR and did not intend to break the original structure.

@nugaon nugaon merged commit 7bd8512 into master Sep 22, 2025
15 checks passed
@nugaon nugaon deleted the fix/ens-error-handling branch September 22, 2025 07:39
@bcsorvasi bcsorvasi added this to the v2.7.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid path params ens name resolution errors

5 participants